Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check multi-currency on jv for common party accounting with foreign currency (backport #43095) #43119

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 9, 2024

Issue:
When creating an invoice for the common party in foreign currency, it throws a multicurrency error while creating advance jv.
https://support.frappe.io/helpdesk/tickets/20825

Solution:
Enabling multi-currency check box based on account currency, while creating advance jv

Screenshot from 2024-09-05 17-15-31

image


This is an automatic backport of pull request #43095 done by [Mergify](https://mergify.com).

venkat102 and others added 4 commits September 9, 2024 05:06
(cherry picked from commit 740a04a)

# Conflicts:
#	erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
(cherry picked from commit 454e18a)
Copy link
Contributor Author

mergify bot commented Sep 9, 2024

Cherry-pick of 740a04a has failed:

On branch mergify/bp/version-14-hotfix/pr-43095
Your branch is ahead of 'origin/version-14-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 740a04a704.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ruthra-kumar ruthra-kumar merged commit c237f3c into version-14-hotfix Sep 9, 2024
10 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-14-hotfix/pr-43095 branch September 9, 2024 05:54
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.74.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants