fix: A project without tasks should be able to complete (backport #42969) #43246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix solves a bug where, when completing a project without tasks, it will fail to close.
If a project without tasks is set to "Completed", either through setting the project status directly or with the "set_project_status" function, the status is not changed but reverted back to "Open".
The reason for this behaviour is, that since there are no tasks to provide a completion percentage erpnext will not accept the "Completed" status.
While failing the bug does not throw an error or warning message to the user, hence I am assuming the behaviour is unintentional and needs to be fixed.
This fix solves the bug by changing the completion type to manual on completing the project if there are no tasks within the project
This is an automatic backport of pull request #42969 done by [Mergify](https://mergify.com).