fix: shipping rule must match the company #43283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
added
backport version-14-hotfix
ruthra-kumar
approved these changes
Sep 23, 2024
This was referenced Sep 23, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Sep 24, 2024
…-43283 fix: shipping rule must match the company (backport #43283)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to allow selecting Shipping Rules that belong to a different Company, which lead to errors due to using foreign income accounts. Now the Shipping Rule must belong to the same company as the corresponding sales transaction.