fix: asset depreciation and balances report correction #43348
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushi8112
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
khushi8112
added
backport version-15-hotfix
and removed
needs-tests
…ing-condition-in-asset-depreciation-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The Asset Depreciation and Balances Report was incorrectly removing some assets. This happened because the condition did not consider assets that were capitalized in the coming year, leading to missing assets in the report.
Resolution:
The condition has been updated to make sure that only assets capitalized within the chosen date range are excluded. This means assets capitalized in the next year will not be removed from the report.