-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exception on register reports when filtered on cost center #43695
Merged
ruthra-kumar
merged 6 commits into
frappe:develop
from
Vishv-024:sales_register_and_parchase_register
Nov 11, 2024
Merged
fix: exception on register reports when filtered on cost center #43695
ruthra-kumar
merged 6 commits into
frappe:develop
from
Vishv-024:sales_register_and_parchase_register
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishv-024
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
October 16, 2024 12:42
Eventhough this solves the exception, it doesn't filter Journals based on the cost center |
ruthra-kumar
force-pushed
the
sales_register_and_parchase_register
branch
from
November 8, 2024 06:34
cf10253
to
f01e1a8
Compare
ruthra-kumar
changed the title
fix: fix the sales register and purchase register cost center report
fix: exception on register reports when filtered on cost center
Nov 8, 2024
ruthra-kumar
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
and removed
needs-tests
This PR needs automated unit-tests.
labels
Nov 8, 2024
ruthra-kumar
force-pushed
the
sales_register_and_parchase_register
branch
from
November 11, 2024 07:07
b95a702
to
d6030e7
Compare
This was referenced Nov 11, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Nov 11, 2024
…-43695 fix: exception on register reports when filtered on cost center (backport #43695)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 11, 2024
…-43695 fix: exception on register reports when filtered on cost center (backport #43695)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Face error in the 2 report
so solve it
solution::
The cost center Filed in not exits in journal Entry Doctype
And if the Field Exits in child Doc then get Local Variable Error so that convert into Global variable