Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception on register reports when filtered on cost center #43695

Merged

Conversation

Vishv-024
Copy link
Contributor

image

Face error in the 2 report

  1. purchase Register
  2. sales Register

so solve it

solution::

The cost center Filed in not exits in journal Entry Doctype
And if the Field Exits in child Doc then get Local Variable Error so that convert into Global variable

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 16, 2024
@ruthra-kumar ruthra-kumar self-assigned this Oct 30, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 October 30, 2024 05:23
@ruthra-kumar
Copy link
Member

Eventhough this solves the exception, it doesn't filter Journals based on the cost center

@ruthra-kumar ruthra-kumar force-pushed the sales_register_and_parchase_register branch from cf10253 to f01e1a8 Compare November 8, 2024 06:34
@ruthra-kumar ruthra-kumar changed the title fix: fix the sales register and purchase register cost center report fix: exception on register reports when filtered on cost center Nov 8, 2024
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Nov 8, 2024
@ruthra-kumar ruthra-kumar force-pushed the sales_register_and_parchase_register branch from b95a702 to d6030e7 Compare November 11, 2024 07:07
@ruthra-kumar ruthra-kumar merged commit ed56a1e into frappe:develop Nov 11, 2024
13 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 11, 2024
…-43695

fix: exception on register reports when filtered on cost center (backport #43695)
ruthra-kumar added a commit that referenced this pull request Nov 11, 2024
…-43695

fix: exception on register reports when filtered on cost center (backport #43695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants