Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ux): realtime communication for ticket: comments/conversations #1050

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix(ux): realtime communication for ticket: comments/conversations #1050

merged 1 commit into from
Mar 13, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Mar 13, 2023 •
edited
Loading

Issue

The event frontend listen to, list_update is not reliable. Hence no updates reach desk

Solution

Trigger a custom event whenever there is a new doc, currently applied to

  • Frappe Desk Comment
  • Communication (from Core, via hooks)

@ssiyad ssiyad linked an issue Mar 13, 2023 that may be closed by this pull request
replies don't reflect immediately #1019
Closed
@ssiyad ssiyad added the bug-fix label Mar 13, 2023
@ssiyad ssiyad merged commit 9d277ca into frappe:main Mar 13, 2023
@ssiyad ssiyad deleted the fix/ticket_communication_realtime branch March 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replies don't reflect immediately
1 participant
@ssiyad