Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kb): list query #1069

Merged
merged 2 commits into from
Mar 19, 2023
Merged

refactor(kb): list query #1069

merged 2 commits into from
Mar 19, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Mar 19, 2023

This PR moves list fetching logic (fields and filters in query) to api (python)

@ssiyad ssiyad added the bug-fix label Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.05 ⚠️

Comparison is base (4a2b544) 12.52% compared to head (6f45808) 12.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   12.52%   12.48%   -0.05%     
==========================================
  Files          52       52              
  Lines        1748     1754       +6     
==========================================
  Hits          219      219              
- Misses       1529     1535       +6     
Impacted Files Coverage Δ
frappedesk/frappedesk/doctype/article/article.py 0.00% <0.00%> (ø)
frappedesk/frappedesk/doctype/category/category.py 0.00% <ø> (ø)
frappedesk/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit 608bb97 into frappe:main Mar 19, 2023
@ssiyad ssiyad deleted the refactor/kb/list_query branch March 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant