Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): filters not getting applied #1247

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jun 5, 2023

No description provided.

@ssiyad ssiyad added the bug-fix label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 24.19% and project coverage change: +0.71 🎉

Comparison is base (75e655f) 12.87% compared to head (edd3783) 13.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   12.87%   13.59%   +0.71%     
==========================================
  Files          52       52              
  Lines        1848     1868      +20     
==========================================
+ Hits          238      254      +16     
- Misses       1610     1614       +4     
Impacted Files Coverage Δ
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <0.00%> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.51% <17.77%> (+<0.01%) ⬆️
helpdesk/utils.py 39.13% <66.66%> (+39.13%) ⬆️
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit d974bd9 into frappe:main Jun 5, 2023
@ssiyad ssiyad deleted the fix/ux/filters_not_applied branch June 5, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant