Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback ticket type #1305

Merged
merged 11 commits into from
Jul 12, 2023
Merged

feat: fallback ticket type #1305

merged 11 commits into from
Jul 12, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jul 11, 2023

This PR will

  • Apply a ticket type even if no default is specified
  • Refactor common hooks in ticket controller

@ssiyad ssiyad added the enhancement New feature or request label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.63 🎉

Comparison is base (75e655f) 12.87% compared to head (a077f97) 13.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
+ Coverage   12.87%   13.51%   +0.63%     
==========================================
  Files          52       54       +2     
  Lines        1848     1931      +83     
==========================================
+ Hits          238      261      +23     
- Misses       1610     1670      +60     
Impacted Files Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/consts.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_agent/hd_agent.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.73% <ø> (+0.22%) ⬆️
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <ø> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
.../helpdesk/doctype/hd_ticket_type/hd_ticket_type.py 0.00% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit cdfd030 into frappe:main Jul 12, 2023
@ssiyad ssiyad deleted the feat/type/uncategorised branch July 12, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant