Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username added in Ticket history #1348

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Username added in Ticket history #1348

merged 2 commits into from
Jul 25, 2023

Conversation

Shivam327
Copy link
Contributor

@Shivam327 Shivam327 commented Jul 25, 2023

Earlier, Ticket history didn't show which user has done the changes.
(Message for all the Update has been slightly changed)

image

Now, Ticket History shows which user has done the changes (Now it works as shown in Helpdesk Homepage UI)

image

Also Ticket creation message has been updated.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.47% 🎉

Comparison is base (75e655f) 12.87% compared to head (e411020) 13.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   12.87%   13.35%   +0.47%     
==========================================
  Files          52       56       +4     
  Lines        1848     1955     +107     
==========================================
+ Hits          238      261      +23     
- Misses       1610     1694      +84     
Files Changed Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/consts.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_agent/hd_agent.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.82% <ø> (+0.30%) ⬆️
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <ø> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
.../helpdesk/doctype/hd_ticket_type/hd_ticket_type.py 0.00% <ø> (ø)
... and 1 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad merged commit 492baa3 into frappe:main Jul 25, 2023
7 of 8 checks passed
@ssiyad ssiyad added the enhancement New feature or request label Jul 25, 2023
@Shivam327 Shivam327 deleted the ticket-history branch July 25, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants