Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reactivity in customer page #1872

Merged
merged 8 commits into from
Jul 19, 2024
Merged

fix: reactivity in customer page #1872

merged 8 commits into from
Jul 19, 2024

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Jul 19, 2024 •
edited
Loading

Issue:

  1. When we add a new customer, the page reloads.
  2. When we update a contact, the dialog does not close.
  3. Failing CI, cause of
    • old semgrep version.
    • Old eslint-plugin-vue package

Solution:

  1. Fixed reactivity in CustomerList and the relevant components.
  2. Upgraded eslint-plugin-vue to latest version
  3. Upgraded semgrep to latest version

@RitvikSardana RitvikSardana marked this pull request as ready for review July 19, 2024 16:26
@RitvikSardana RitvikSardana merged commit a152df4 into frappe:develop Jul 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RitvikSardana