fix: update repay_from_salary and payroll_payable_account fields #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
approved these changes
Sep 6, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit d6c812e) # Conflicts: # hrms/patches.txt # hrms/setup.py
ruchamahabal
reviewed
Sep 6, 2023
Comment on lines
+10
to
+16
| if frappe.db.exists("Custom Field", {"name": "Loan Repayment-payroll_payable_account"}): | ||
| frappe.db.set_value( | ||
| "Custom Field", | ||
| {"name": "Loan Repayment-payroll_payable_account"}, | ||
| "insert_after", | ||
| "payment_account", | ||
| ) |
There was a problem hiding this comment.
I think this was placed with the repay from salary checkbox since its visibility is dependent on toggling the checkbox. But moving it to the accounts section for context is also fine IG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loan Repayment'srepay_from_salaryeditableLoan Repayment'sPayroll Payable Accountto a better position (among other accounts)