Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url for lesson help videos #1021

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pateljannat
Copy link
Collaborator

Issue: The URLs of the lesson help videos were not working.

Fix: Changed them to /assets/lms/frontend/.. to make it work.

Copy link

cypress bot commented Sep 18, 2024

lms    Run #683

Run Properties:  status check passed Passed #683  •  git commit cceaf528b6 ℹ️: Merge 14ce5d7e235f601692fa47726560ebe8fc462cc6 into b6422d104666995d8d71be49f8de...
Project lms
Branch Review fix-help-video-url
Run status status check passed Passed #683
Run duration 00m 30s
Commit git commit cceaf528b6 ℹ️: Merge 14ce5d7e235f601692fa47726560ebe8fc462cc6 into b6422d104666995d8d71be49f8de...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 545326a into frappe:develop Sep 18, 2024
5 checks passed
@pateljannat pateljannat deleted the fix-help-video-url branch September 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant