Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: course categories #1025

Merged
merged 8 commits into from
Sep 24, 2024
Merged

feat: course categories #1025

merged 8 commits into from
Sep 24, 2024

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Sep 20, 2024 •
edited
Loading

  1. You can now assign categories to courses, just like batches.
  2. The category filter will be visible at the top of the course list.
  3. When a user selects a category the list will be filtered to show courses of only that category.
  4. The same category will also be added to the URL, which can be shared with others.
  5. The Settings page will have a Categories section.
  6. Moderators can add new categories or edit existing categories from here.
categories.mp4

@pateljannat pateljannat changed the title feat: category in settings feat: course categories Sep 23, 2024
@pateljannat pateljannat marked this pull request as ready for review September 24, 2024 05:29
@cypress Cypress
Copy link

cypress bot commented Sep 24, 2024 •
edited
Loading

lms    Run #691

Run Properties:  status check passed Passed #691  •  git commit d47f546cc8 ℹ️: Merge ad5bf89b3561da8d3b73382bd5875dbe0b550300 into 9609329f01fb3f57a61d9dd164d2...
Project lms
Branch Review categories-in-courses
Run status status check passed Passed #691
Run duration 00m 43s
Commit git commit d47f546cc8 ℹ️: Merge ad5bf89b3561da8d3b73382bd5875dbe0b550300 into 9609329f01fb3f57a61d9dd164d2...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 04552bd into frappe:develop Sep 24, 2024
5 checks passed
@pateljannat pateljannat deleted the categories-in-courses branch September 24, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pateljannat