Merge pull request #243 from mgiadach/fix/pages-on-sidebar

fix: prevent private pages from showing in sidebar
frappe · Jun 5, 2024 · c01ecd2 · c01ecd2
2 parents b309ca0 + 5d530fc
commit c01ecd2
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/wiki/wiki/doctype/wiki_page/wiki_page.py b/wiki/wiki/doctype/wiki_page/wiki_page.py
@@ -317,6 +317,12 @@ def get_sidebar_items(self):
 				continue
 
 			wiki_page = frappe.get_doc("Wiki Page", sidebar_item.wiki_page)
+
+			if not wiki_page.allow_guest:
+				permitted = frappe.has_permission(wiki_page.doctype, "read", wiki_page)
+				if not permitted:
+					continue
+
 			if sidebar_item.parent_label not in sidebar:
 				sidebar[sidebar_item.parent_label] = [
 					{