ROFLPlayer causing client to repair

[fraxiinus]

Mirror of this particular comment: #17 (comment)

[ghost]

Hey there !

Here is the content of the Default file I used :
{"Name":"Default","TargetPath":"C:\\Riot Games\\League of Legends\\Game\\League of Legends.exe","StartFolder":"C:\\Riot Games\\League of Legends","PatchVersion":"9.9.272.4950","AllowUpdates":true,"IsDefault":true,"ModifiedDate":"2019-05-07T17:55:44.2212944-04:00"}

I don't think the problem is coming from your ROLF player, but it's either coming from the path used or from Riot messing up their files.

The replay does open and works perfectly fine. But it's not detected by league director. And the next time I open the client, it will need a 3min repair. (Replays work without a problem when launched from the client in my match history)

I did contact Riot support today and here is their answer :

I don't know how much the support's answer is reliable, but they said replays shouldn't work anymore outside of the profile.

[fraxiinus]

So it seems that there are some serious issues going on with the replay system in general. Like you said, this issue is probably not coming from ROFLPlayer. I'll keep a look out on any other developments.

[fraxiinus]

Client crashes should now be fixed in patch 9.11
I will keep this issue open in case the crashes continues.

[ghost]

Hey there !
I tested it again, and the client still had to do a repair after I opened it :/

[fraxiinus]

Can you try setting the start folder in your exec file to C:\\Riot Games\\League of Legends\\Game? Client repairing is a sign that the replay is not being launched from the same directory as the game.

[ghost]

Hey again !
I tried it right away :

I changed it in the json file as you told me and you can see the change reflected into the app.
But I still got the repair.
PS: I didn't update to 0.9b if that can be useful for you.

[fraxiinus]

Updating to 0.9b shouldn't do much to fix this problem. You can try though.

Maybe it's because of where ROFLPlayer is being run from?

[ghost]

Where do you suggest I run it from?

[fraxiinus]

I put ROFLPlayer in my replay folder in My Documents.

[ghost]

It didn't fix the problem for me.
I also moved to the new version.

I'm pretty surprised you didn't encounter this bug

[fraxiinus]

Yeah this problem is still stumping me. Are you able to 100% reproduce the bug? If you can, can you share what you do to have the bug occur? Is there maybe a pattern of how you close the game and start another?

[ghost]

Yes, I can confirm that the bug occurs 100% of the time. I also showed the app to a friend and he's encountering the same thing.

To reproduce :
Play a rofl file with ROFL Player. I close them by going into the setting then I click on exit. I then see the "are you sure you want to exit" as if you want to go afk in a game. Pretty normal.

Then on my next opening of the client (either by opening it directly, or closing it and open it if it was open while using rofl player), it will do a very small repair that takes about 3min.
It only happens when I open the client, not when I launch a game or play another rofl.

If you want, I can show you in a screenshare on discord when we both have time.

[fraxiinus]

Hoorah! I'm able to reproduce the bug.

This bug is happening because the game client is still trying to look for the RADS directories even though Riot stopped using RADS. I'll be able to fix this soon!

[ghost]

Hooray !
It was a pain, Glad to know it's gonna get fixed soon !

And thanks a lot for your hard work !

[fraxiinus]

Tested and Resolved in 5f40819

Changes:

• ROFLPlayer will now properly set the ProcessStartInfo instead of using the shortcut hack to play replays.
• ROFLPlayer now uses correct launch arguments when playing replays

These changes will be pushed into the next release

[ghost]

Awesome !

I'll be waiting for the next release

[fraxiinus]

Fix released in https://github.com/leeanchu/ROFL-Player/releases/tag/1.0