Initialize Package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a purposely malformed `package.json` file in one of the dependencies (for testing purposes). We are using `.flowconfig` to ignore this file. See issue: facebook/flow#2364.
StevenXL
force-pushed
the
sl/initialize-package
branch
from
3fa4152 to
aa0fb64
Compare
StevenXL
force-pushed
the
sl/initialize-package
branch
from
b77f5e0 to
aece6fe
Compare
StevenXL
force-pushed
the
sl/initialize-package
branch
from
aece6fe to
8f1c02f
Compare
Use `flow-typed` to download the `library definitions` for the current version of `jest`.
StevenXL
commented
Apr 8, 2022
| @@ -0,0 +1,13 @@ | |||
| [ignore] | |||
| .*/node_modules/resolve/test/resolver/malformed_package_json/package.json | |||
There was a problem hiding this comment.
See: facebook/flow#2364
StevenXL
force-pushed
the
sl/initialize-package
branch
from
e9b4122 to
d801d9f
Compare
StevenXL
commented
Apr 8, 2022
stackptr
requested changes
Apr 8, 2022
| @@ -0,0 +1,3 @@ | |||
| # @freckle/react-hooks | |||
|
|
|||
| Provides a collection of React hooks. | |||
There was a problem hiding this comment.
useExtraDeps is only used internally, but I see that type CallbackFn and unCallbackFn is imported across the Freckle frontends. It's exported in this extracted module to avoid cyclical dependencies. After use-safe-callback is extracted, these should be documented
StevenXL
force-pushed
the
sl/initialize-package
branch
2 times, most recently
from
cd1c983 to
fbaf418
Compare
StevenXL
force-pushed
the
sl/initialize-package
branch
from
fbaf418 to
ad2f6d5
Compare
StevenXL
commented
Apr 11, 2022
| @@ -0,0 +1,9 @@ | |||
| // @flow | |||
|
|
|||
| export type { PrimitiveDep, CallbackFn, ExtraDeps } from "./use-extra-deps"; | |||
There was a problem hiding this comment.
See: facebook/flow#1379
stackptr
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
useExtraDepsfromentities.Note that the test suite for
useExtraDepshas been ported over and passes.As a further smoke test, I was able to add this package to
entitiesvia:The test suite
entities/.../use-extra-deps/index.test.jspassed when usingimport {useExtraDeps} from '@freckle/react-hooks'. I was also able to useimport { type CallbackFn, type PrimitiveDep, type ExtraDeps, useExtraDeps } from '@freckle/react-hooks'inentities/.../use-async/index.jsand that test suite also passed.