Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse error for some matrix environment #14

Closed
rgaiacs opened this issue Jan 29, 2014 · 1 comment
Closed

Parse error for some matrix environment #14

rgaiacs opened this issue Jan 29, 2014 · 1 comment
Labels
Milestone

Comments

@rgaiacs
Copy link
Collaborator

rgaiacs commented Jan 29, 2014

The amsmath package define six environments for matrix:

  • matrix,
  • pmatrix,
  • bmatrix,
  • Bmatrix,
  • vmatrix,
  • Vmatrix.

For bmatrix, Bmatrix and Vmatrix we got a parse error.

Steps to reproduce

  • Build the parser
  • Open index.html with Firefox.
  • Type in the box (you can replace bmatrix with Bmatrix or Vmatrix):
\begin{bmatrix}
a_11 & a_12 \\
a_21 & a_22
\end{bmatrix}
  • Press 'TAB'.
@fred-wang
Copy link
Owner

Thanks, I think that is easy to fix, one just has to ensure that the open and close environment names match:
https://github.com/fred-wang/TeXZilla/blob/master/base-commands.txt#L28
https://github.com/fred-wang/TeXZilla/blob/master/base-commands.txt#L65
https://github.com/fred-wang/TeXZilla/blob/master/TeXZilla.jison#L586

We also need unit tests for each command, that's not the case for matrix environments (issue #13)

rgaiacs pushed a commit to rgaiacs/TeXZilla that referenced this issue Jan 29, 2014
- Fix typos
- Add test for matrices environments

This should close issue fred-wang#14.

NOTE: the matrices environments came from amsmath package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants