Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not introduce extra mstyle elements to set presentation attributes on token elements #61

Closed
fred-wang opened this issue Apr 13, 2019 · 3 comments
Closed

Do not introduce extra mstyle elements to set presentation attributes on token elements #61

fred-wang opened this issue Apr 13, 2019 · 3 comments

Comments

@fred-wang
Copy link
Owner

Follow-up of #10

For example the mathvariant or color attributes can just be set on token elements.

test: \mathfrak{a}
@fred-wang fred-wang mentioned this issue Apr 13, 2019
Open
fred-wang added a commit that referenced this issue Apr 13, 2019
@fred-wang
Use newMrow to create mstyle elements. #61
6832195
fred-wang added a commit that referenced this issue Apr 13, 2019
@fred-wang
Avoid extra mstyle attribute when setting mathvariant/mathcolor/mathb…
f6dc9af 
…ackground on a single token element. #61
@fred-wang
Copy link
Owner Author

fred-wang commented Apr 13, 2019 •
edited
Loading

test: \mathfrak{a}

The basic case (single token) is now fixed. mstyle is still used for more complex markup e.g. \mathfrak{sl}, \mathfrak{x+y} or \mathfrak{\frac{x}{y}}. I guess a solution would require to do a top-to-bottom pass, but that might decrease the performance and might not be very useful in practice.

fred-wang added a commit that referenced this issue Apr 14, 2019
@fred-wang
Add FIXME and tests for basic things like \mathfrak{sl}. #61
17c5794
fred-wang added a commit that referenced this issue Apr 28, 2019
@fred-wang
Do not introduce unnecessary mstyle to apply mathvariant on multiple …
6f0f4af 
…token element children. #61

For example \\mathfrak{sl} or \\mathfrak{x+y}
However, we still keep the mstyle when applying colors on multiple token element children, instead of repeating the attribute.
@fred-wang
Copy link
Owner Author

Cases like \mathfrak{sl} or \mathfrak{x+y} with multiple token element children no longer uses an mstyle.

More complex case like \mathfrak{\frac{x}{y}} are not. I'm not really sure they are worth an additional top-to-bottom pass. Leaving this issue opened in case that is desired. Maybe we can do like LaTeXML and introduce an option to force the mathvariant transforms everywhere.

@fred-wang
Copy link
Owner Author

Actually closing this and moving the remaining case to #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fred-wang