Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored continued=false in parse() #65

Closed
wants to merge 1 commit into from

Conversation

ggarza
Copy link

@ggarza ggarza commented May 29, 2019

This fixes a situation where the continued=false option in parse() was
ignored during notebook export.

The code can further be cleaned up by combining the block changed with the next block in an if-else-end block. However, I went with the most minimal change here.

This partially addresses #41.

This fixes a situation where the continued=false option in parse() was
ignored during notebook export.
@fredrikekre
Copy link
Owner

Hello @ggarza and thanks for the PR! I'm sorry, I completely forgot about this one. I just reworked the "continued" code in 36e8c21 so the code-block you change here is removed now. Did you have a specific example where you got an error? Could be worth to see if it fixed by the commit.

@ggarza
Copy link
Author

ggarza commented Jul 19, 2019

I believe your commit addresses the same thing. You can close this.

Thanks.

@fredrikekre
Copy link
Owner

Great, thanks again, and sorry for being slow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants