Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl version and pager icon direction #275

Closed
afattahi54 opened this issue Oct 29, 2016 · 7 comments
Closed

rtl version and pager icon direction #275

afattahi54 opened this issue Oct 29, 2016 · 7 comments
Labels

Comments

@afattahi54
Copy link

When we set the page direction to RTL, the direction of pager icons does not change.

Please see https://jsfiddle.net/tn48Letf/

The old jqGrid, used to switch the icon directions, please see: http://jsfiddle.net/58g6e61f/

Thanks!

@OlegKi
Copy link
Member

OlegKi commented Oct 29, 2016

Do you mean that the correct look of the icons in RTL mode would be

  • "ui-icon-seek-first" of "fa-step-backward" should be used for go to the last page
  • "ui-icon-seek-prev" or "fa-backward" should be used as the next page
  • "ui-icon-seek-next" or "fa-forward" should be used as the previous page
  • "ui-icon-seek-end" of "fa-step-forward" should be used for go to the first page

Is it correct in general for RTL mode? If you confirm that then I would fix the problem in free jqGrid.

OlegKi added a commit that referenced this issue Oct 29, 2016
Thanks @afattahi54 (https://github.com/afattahi54) for reporting the problem. See [the issue](#275) for more details.
@OlegKi
Copy link
Member

OlegKi commented Oct 29, 2016

I thought more about the problem and posted the fix. Please verify, whether the current code produces the correct pager items. I'm not sure, which language is your first one (the native language), but I suppose it's the Persian language. Look at the modified demo https://jsfiddle.net/OlegKi/tn48Letf/1/. It uses the new code from GitHub and I hope it displays the correct pager buttons.

By the way, the locale file grid.locale-fa.js, grid.locale-ar.js and other contain some non-localized texts (see here, here and here). It would be helpful for other if you would translate the missing texts and sent there to me. You can post pull request or just send the translations in the next comment.

@afattahi54
Copy link
Author

Thanks, the icon in produced grid is fine .
Here are translations:

showhide: "تغییر وضعیت نمایش جدول",
.....
addGroupTitle: "اضافه کردن عنوان گروه",
deleteGroupTitle: "حذف عنوان گروه",
addRuleTitle: "اضافه کردن  عنوانقانون",
deleteRuleTitle: "حذف عنوان قانون",
operandTitle: "برای انتخاب گزینه های جستجو کلیک کنید",

OlegKi added a commit that referenced this issue Oct 30, 2016
@OlegKi
Copy link
Member

OlegKi commented Oct 30, 2016

Thanks for the information. I posted the commit, which contains all your changes and some other changes of the week days and months which I get from the official Unicode CLDR Charts.

Some other texts are still in English: "savetitle" and "canceltitle" (see here). Try https://jsfiddle.net/OlegKi/tn48Letf/3/, click on any row. You will see Save and Cancel buttons in the navigator bar added by inlineNav. Hover the buttons and you will see the texts "Save row" and "Cancel row editing" displayed as Tooltips. Could you translate the texts too to make full translation of the grid.locale-fa.js?

@OlegKi OlegKi added the bug label Nov 1, 2016
@OlegKi
Copy link
Member

OlegKi commented Nov 1, 2016

The bug reported in the issue is fixed. I'm waiting still your feedback about translation of the words to Persian language, but it's a separate subject. Thus I close the issue.

@OlegKi OlegKi closed this as completed Nov 1, 2016
@afattahi54
Copy link
Author

Thanks.. Here are the remaining translations:

savetitle: "ذخیره سطر",

canceltitle: "انصراف از تغییر سطر"

OlegKi added a commit that referenced this issue Nov 1, 2016
@OlegKi
Copy link
Member

OlegKi commented Nov 1, 2016

Thank you. I included the changes in the main code of free jqGrid (see the commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants