Update reload_host_config script with iptables rule drop and root credentials caching #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some commands to drop all previously applied iptables rules (it helps if running in an already setup OS or if the script is run more than once) Add a root credential cache command (to avoid asking for the password in the middle of the workflow) Add some inline comments to improve code readability
linouxis9
reviewed
Apr 5, 2024
Add a parameter to control if the script will delete or not all the iptables rules. Thanks @linouxis9 for suggesting this modification in free5gc#554 (comment) Add some safeguards to avoid errors while running the script
Add a safeguard to avoid entering more than two parameters on the script
oliveiraleo
added a commit
to oliveiraleo/free5gc-auto-deploy
that referenced
this pull request
Apr 22, 2024
Warn the user before deleting all the iptables rules For more context, see this discussion here: free5gc/free5gc#554 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has these actions:
Add some commands to drop all previously applied iptables rules (it helps if running in an already setup OS or if the script is run more than once) (for more information, see this doc page)
Add a root credential cache command (to avoid asking for the password in the middle of the workflow)
Add some inline comments to improve code readability and hopefully reduce future maintenance efforts
TIA