refactor and update util to use new log formatter setting #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
May 4, 2023
go.mod
Outdated
| github.com/sirupsen/logrus v1.8.1 | ||
| github.com/urfave/cli v1.22.5 | ||
| github.com/vishvananda/netlink v1.1.0 | ||
| github.com/wmnsk/go-gtp v0.8.0 | ||
| github.com/wmnsk/go-gtp v0.7.28 |
tim-ywliu
reviewed
May 4, 2023
go.mod
Outdated
| github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d | ||
| github.com/free5gc/aper v1.0.4 | ||
| github.com/free5gc/ngap v1.0.6 | ||
| github.com/free5gc/util v1.0.3 | ||
| github.com/free5gc/util v1.0.4 |
There was a problem hiding this comment.
should be v1.0.5-0.20230306071612-a52909216bd2
tim-ywliu
reviewed
May 4, 2023
internal/ngap/handler/handler.go
Outdated
| @@ -429,126 +421,127 @@ func HandleInitialContextSetupRequest(amf *context.N3IWFAMF, message *ngapType.N | |||
| var emergencyFallbackIndicator *ngapType.EmergencyFallbackIndicator | |||
| var iesCriticalityDiagnostics ngapType.CriticalityDiagnosticsIEList | |||
|
|
|||
| var n3iwfUe *context.N3IWFUe | |||
| var n3iwfRanUe *context.N3IWFRanUe | |||
There was a problem hiding this comment.
replace all n3iwfRanUe with ranUe
tim-ywliu
reviewed
May 4, 2023
| @@ -84,36 +406,117 @@ func N3IWFSelf() *N3IWFContext { | |||
| return &n3iwfContext | |||
| } | |||
|
|
|||
| func (context *N3IWFContext) NewN3iwfUe() *N3IWFUe { | |||
| func (context *N3IWFContext) NewN3iwfIkeUe(spi uint64) *N3IWFIkeUe { | |||
| n3iwfIkeUe := new(N3IWFIkeUe) | |||
There was a problem hiding this comment.
replace all n3iwfIkeUe with ikeUe
tim-ywliu
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.