Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGAP fuzzing #7

Merged
merged 5 commits into from
Jun 14, 2023
Merged

NGAP fuzzing #7

merged 5 commits into from
Jun 14, 2023

Conversation

ShouheiNishi
Copy link
Contributor

Add fuzzing code and data for ngap.Decoder().
This PR requires free5gc/aper#5.

@ss920386
Copy link

Hi @ShouheiNishi , thanks for your PR. If I didn't get it wrong, files in testdata/fuzz/fuzzNGAP are the fuzz test cases just for reproduction, right? 9fe2749e39dbbc2d is the test case related to your aper PR which has unit test already, and the others are randomly generated tests by go fuzz. If those are the cases, should we add those files to .gitignore for this PR?

@ShouheiNishi
Copy link
Contributor Author

Hi @ShouheiNishi , thanks for your PR. If I didn't get it wrong, files in testdata/fuzz/fuzzNGAP are the fuzz test cases just for reproduction, right? 9fe2749e39dbbc2d is the test case related to your aper PR which has unit test already, and the others are randomly generated tests by go fuzz. If those are the cases, should we add those files to .gitignore for this PR?

The files testdata/fuzz/fuzzNGAP/ci* are generated from the packet capture during testing and are considered useful as a seed corpus for fuzzing.

@tim-ywliu
Copy link
Collaborator

@ShouheiNishi
free5gc/aper#5 is merged. Please update the aper hash.

@tim-ywliu tim-ywliu merged commit 1373640 into free5gc:main Jun 14, 2023
ianchen0119
ianchen0119 reviewed Jul 26, 2023
View reviewed changes
testdata/fuzz/FuzzNGAP/ci0000
@@ -0,0 +1,2 @@
go test fuzz v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShouheiNishi

I'm wondering how did you generate all the ciXXXX files.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianchen0119 ianchen0119 ianchen0119 left review comments

@tim-ywliu tim-ywliu tim-ywliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShouheiNishi @ss920386 @tim-ywliu @ianchen0119