Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: App, Server, Processor, Consumer #26

Merged
merged 22 commits into from
Jun 27, 2024
Merged

refactor: App, Server, Processor, Consumer #26

merged 22 commits into from
Jun 27, 2024

Conversation

HanHongChen
Copy link
Contributor

@HanHongChen HanHongChen commented May 8, 2024 •
edited
Loading

  1. consumer
  • amf_service.go
  • nrf_service.go
  • udr_service.go
  • consumer.go
  • make
  1. service
  • copy server side code
  • implement server structure & refactor sbi_{SVC}.go
  • Add GetCertPemPath() & GetCertKeyPath()
  • Remove Legacy Code
  • RegisterNFInstance()
  1. Processor
  • processor/processor.go
  • change producer to processor
  • tear down response and request
  • run free5gc

@andy89923 andy89923 changed the title Refactor/sbi logic refactor: App, Server, Processor, Consumer May 28, 2024
@andy89923 andy89923 self-requested a review May 28, 2024 04:15
@HanHongChen HanHongChen force-pushed the refactor/sbi-logic branch from 6351765 to c4ec427 Compare June 3, 2024 07:07
@andy89923
Copy link
Contributor

Is this PR ready for review?

andy89923
andy89923 reviewed Jun 4, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
yccodr
yccodr reviewed Jun 6, 2024
View reviewed changes
Copy link

@yccodr yccodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR ready for merge? It's still in draft.

internal/sbi/api_httpcallback.go Show resolved Hide resolved
internal/sbi/api_httpcallback.go Show resolved Hide resolved
internal/sbi/api_oam.go Outdated Show resolved Hide resolved
internal/sbi/api_smpolicy.go Show resolved Hide resolved
internal/sbi/api_uepolicy.go Outdated Show resolved Hide resolved
internal/sbi/consumer/nrf_service.go Show resolved Hide resolved
internal/sbi/processor/bdtpolicy.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
@HanHongChen HanHongChen marked this pull request as ready for review June 10, 2024 15:10
andy89923
andy89923 reviewed Jun 11, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
internal/sbi/api_httpcallback.go Outdated Show resolved Hide resolved
@andy89923
Copy link
Contributor

The code inside terminate and terminateProcedure are not correct. Please check again.

andy89923
andy89923 reviewed Jun 21, 2024
View reviewed changes
pkg/service/init.go Outdated Show resolved Hide resolved
andy89923
andy89923 previously approved these changes Jun 25, 2024
View reviewed changes
@andy89923 andy89923 dismissed their stale review June 25, 2024 10:20

not ready

andy89923
andy89923 reviewed Jun 25, 2024
View reviewed changes
internal/sbi/processor/callback.go Outdated Show resolved Hide resolved
internal/sbi/processor/smpolicy.go Outdated Show resolved Hide resolved
internal/sbi/processor/smpolicy.go Outdated Show resolved Hide resolved
internal/sbi/processor/smpolicy.go Outdated Show resolved Hide resolved
andy89923
andy89923 reviewed Jun 26, 2024
View reviewed changes
internal/sbi/processor/processor.go Outdated Show resolved Hide resolved
internal/sbi/processor/policyauthorization.go Outdated Show resolved Hide resolved
internal/sbi/processor/policyauthorization.go Outdated Show resolved Hide resolved
internal/sbi/processor/policyauthorization.go Outdated Show resolved Hide resolved
internal/sbi/processor/policyauthorization.go Outdated Show resolved Hide resolved
internal/sbi/processor/smpolicy.go Outdated Show resolved Hide resolved
internal/sbi/processor/smpolicy.go Outdated Show resolved Hide resolved
internal/sbi/server.go Outdated Show resolved Hide resolved
pkg/service/init.go Outdated Show resolved Hide resolved
andy89923
andy89923 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andy89923 andy89923 requested a review from ianchen0119 June 26, 2024 17:17
ianchen0119
ianchen0119 reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@ianchen0119 ianchen0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me.

@ianchen0119 ianchen0119 merged commit 7df0d40 into free5gc:main Jun 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yccodr yccodr yccodr left review comments

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@andy89923 andy89923 andy89923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HanHongChen @andy89923 @yccodr @ianchen0119