Fix: Raise Error Log when Uplink/Downlink AMBR missing unit

[ntut-xuan]

What's happened?

Hi, I'm Uriah from NYCU Room 215 😄

In this PR, I fix when Uplink/Downlink AMBR in webconsole subscriber page doesn't have unit, it will rasie panic in free5gc SMF.

In above image, the Uplink/Downlink AMBR doesn't have unit (Mbps or Kbps), it will make free5gc raise panic in below image.

I add error handling in BitRateTokbps function and raise Error in ActivateTunnelAndPDR function when BitRateTokbps function raise the error.

Implmentation

• Add error handling in ActivateTunnelAndPDR

How to review?

• Check when Uplink/Downlink AMBR doesn't have unit, it should raise error instead of raw panic.

[ianchen0119]

@ntut-xuan

Thanks for your PR.
Please help to fix the ci-linter error.

@andy89923
Please help to review it when you feel free.

[ntut-xuan]

@ntut-xuan

Thanks for your PR. Please help to fix the ci-linter error.

@andy89923 Please help to review it when you feel free.

Hi @ianchen0119, lint issue is fixed. Please approve the workflows.

[andy89923]

Hi @ntut-xuan,

Thanks for the PR!

Overall it's LGTM, but I think we should add Test for the function under util, such as TestBitRateTokbps and TestBitRateTombps.

Could you help with the test function? Or I can provide test function and you help with the testcase.

[ntut-xuan]

Hi @ntut-xuan,

Thanks for the PR!

Overall it's LGTM, but I think we should add Test for the function under util, such as TestBitRateTokbps and TestBitRateTombps.

Could you help with the test function? Or I can provide test function and you help with the testcase.

No problem. I'll add it soon.

[ntut-xuan]

Hi @ianchen0119 and @andy89923:

I already add the tests and check the implementation passed lint-chcek.
All testcase follows AAA pattern and it should show what the testcase check clearly. Please review it, thanks!

Since we don't have a folder of tests, I add a folder /internal/util/tests, it should use to contain test file in future.

[andy89923]

LGTM!
@ianchen0119