changed sd to lowercase #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianchennn
approved these changes
Jul 29, 2023
tim-ywliu
reviewed
Jul 31, 2023
pkg/factory/factory.go
Outdated
| // userplaneInformation | ||
| UPNodes := cfg.Configuration.UserPlaneInformation.UPNodes | ||
| for i := range UPNodes { | ||
| if UPNodes[i].SNssaiInfos != nil { |
There was a problem hiding this comment.
no need this if. remove it.
tim-ywliu
approved these changes
Aug 1, 2023
tim-ywliu
added a commit
that referenced
this pull request
Aug 6, 2023
danielh1204
pushed a commit
to danielh1204/smf
that referenced
this pull request
Aug 11, 2023
change sd to lowercase gofumpt-ed deleted if use EqualFold changed sd to lowercase (free5gc#81) * change sd to lowercase * gofumpt-ed * deleted if Revert "changed sd to lowercase (free5gc#81)" (free5gc#83) This reverts commit abec5ee.
danielh1204
added a commit
to danielh1204/smf
that referenced
this pull request
Aug 11, 2023
gofumpt-ed deleted if use EqualFold changed sd to lowercase (free5gc#81) * change sd to lowercase * gofumpt-ed * deleted if Revert "changed sd to lowercase (free5gc#81)" (free5gc#83) This reverts commit abec5ee.
tim-ywliu
pushed a commit
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.