Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UECM Registration and Deregistration for a PDU Session #92

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Add support for UECM Registration and Deregistration for a PDU Session #92

merged 3 commits into from
Jan 17, 2024

Conversation

saileshvvr
Copy link
Contributor

Added support in SMF for UECM Registration and Deregistration for a PDU Session

@saileshvvr saileshvvr mentioned this pull request Jan 6, 2024
Merged
ianchen0119
ianchen0119 requested changes Jan 15, 2024
View reviewed changes
internal/sbi/consumer/ue_context_management.go
}
}
}()
if localErr == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

smCtx.UeCmRegistered = false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, As suggested, updated the state in the UeCmDeregistration()

internal/sbi/producer/pdu_session.go Outdated
} else {
logger.PduSessLog.Traceln("UECM_DeRegistration successful")
}
smContext.UeCmRegistered = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change the state in UeCmDeregistration()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed the code duplication and set the state inside UeCmDeregistration()

@ianchen0119
Copy link
Contributor

Hi @saileshvvr

Thanks for your PRs.
Please help to fix the ci-lint error when you feel free.

@saileshvvr
Copy link
Contributor Author

Hi @ianchen0119
Thanks for the suggestion. I have addressed the comments in latest patch.

@saileshvvr
Copy link
Contributor Author

Hi @ianchen0119
Thanks for adding the commit to resolve ci linter.

@saileshvvr
Copy link
Contributor Author

Hi @ianchen0119
Could you please help share process for merging the PR.

@ianchen0119
Copy link
Contributor

Hi @saileshvvr

This PR will also be reviewed by @tim-ywliu
It will be merged once it gets the approval by him.

Thank you.

@saileshvvr
Copy link
Contributor Author

Thanks @ianchen0119

@tim-ywliu tim-ywliu merged commit 05c55bb into free5gc:main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-ywliu tim-ywliu tim-ywliu approved these changes

@ianchen0119 ianchen0119 Awaiting requested review from ianchen0119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saileshvvr @ianchen0119 @tim-ywliu