Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogLevel is not applied when the test is run. #5

Merged
merged 2 commits into from
Apr 7, 2022
Merged

LogLevel is not applied when the test is run. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e15ab
LogLevel is not applied when the test is run.
RyuichiNamba-fj Apr 5, 2022
ddae648
fix golangci-lint.yml
RyuichiNamba-fj Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,17 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: '1.14.4'
- uses: actions/checkout@v2
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v2
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.35.0
skip-go-installation: true

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
4 changes: 2 additions & 2 deletions pkg/service/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (udr *UDR) Initialize(c *cli.Context) error {
}
}

udr.setLogLevel()
udr.SetLogLevel()

if err := factory.CheckConfigVersion(); err != nil {
return err
Expand All @@ -85,7 +85,7 @@ func (udr *UDR) Initialize(c *cli.Context) error {
return nil
}

func (udr *UDR) setLogLevel() {
func (udr *UDR) SetLogLevel() {
if factory.UdrConfig.Logger == nil {
logger.InitLog.Warnln("UDR config without log level setting!!!")
return
Expand Down