fix: query strength && dst IP "assigned" #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Add as below and replace all "any" & "assigned" with const.
const (
Any string = "any"
Assigned string = "assigned"
)
tim-ywliu
reviewed
Dec 5, 2023
flowdesc/ip_filter_rule.go
Outdated
| @@ -168,7 +168,7 @@ func Encode(r *IPFilterRule) (string, error) { | |||
| return "", flowDescErrorf("destination addresses format error %s", dst) | |||
| } | |||
| } else { | |||
| ipFilterRuleStr = append(ipFilterRuleStr, "any") | |||
| ipFilterRuleStr = append(ipFilterRuleStr, "assigned") | |||
tim-ywliu
approved these changes
Dec 5, 2023
brianchennn
added a commit
to brianchennn/util
that referenced
this pull request
Aug 13, 2024
* fix: RestfulAPIPutOne( ... , opt) * fix: destination IP (any -> assigned) * refactor: move collation into if scope * add const Any, Assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 Issues
queryStrength= 2 to do case-insensitive query to MongoDB