-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many properties now are set to required in webconsole.yaml #70
Conversation
Hi @newb1er Please help to review PR. |
@ShouheiNish Appreciate your work! Overall, LGTM. But there's one more thing, I don't think we need If you intended to specify the version of |
@ShouheiNishi Here's my suggestion on the script
I don't have Java runtime on my machine so I turn to the Docker option. Wait for your comments. |
…0 according to the review comment
We openapitools.json and regenerate by openapi-generator-cli 7.2.0. |
@ShouheiNishi Thanks for your work! @ianchen0119 @andy89923 Please merge this PR 🙏 |
@ShouheiNishi Please help solve the conflicts. |
… edited, the original file webconsole.yaml is modified and api.ts is regenerated.
Fix conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Many properties of objects in webconsole.yaml are defined as optional.
But go field corresponding to many of these does not has omitempty tag.
So, we add these properties are set to required.