Update nodejs version on readme instructions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2024
yccodr
reviewed
Feb 15, 2024
Co-authored-by: Michael <michael.cs08@nycu.edu.tw>
Co-authored-by: Michael <michael.cs08@nycu.edu.tw>
Co-authored-by: Michael <michael.cs08@nycu.edu.tw>
andy89923
reviewed
Feb 21, 2024
As suggested by @andy89923 in free5gc#71 (comment) corepack needs to be called to setup yarn Later, yarn is used to build the webconsole module
Following the discussion on free5gc#71 and according to the comment free5gc#71 (comment) as yarn will be setup by corepack, there's no need to install it manually anymore
It's necessary to give permission for corepack to install/edit binary files on system /usr/bin folder
|
While testing free5gc, I found that root permission is necessary in order to allow corepack to correctly setup its environment on
To fix this behavior, it's only a matter of appending
Regards, Leo. |
oliveiraleo
added a commit
to oliveiraleo/free5gc
that referenced
this pull request
Feb 29, 2024
According to what was discussed on this PR free5gc/webconsole#71 on webconsole repo, corepack requires permission to correctly setup its files
tim-ywliu
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When building webconsole from scratch using nodejs packed by Ubuntu's official package repositories, I ran into the same issue as the one described here: #25
When trying to follow the instructions on the README file, I received a deprecation warning from nodejs script. Then, according to this document here, the currently supported versions of nodejs are 18, 19 and 20. From the information of this other issue here on the free5gc main repo by me, I chose to install version 18.x and then webconsole built successfully.
This PR will update the instructions on the readme file on this repo too
PS: ASAP I'll update the instructions on the free5gc guide so we have the most up to date information in both places
TIA