Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering errors (missing key and h3 child of TableHeader) #94

Merged
merged 1 commit into from
May 10, 2024

Conversation

LaumiH
Copy link

@LaumiH LaumiH commented May 6, 2024

The charging table page showed two errors:

  1. The table did not have unique keys/ identifiers for every row due to wrapping each TableRow in a fragment (<>...</>), which doesn't pass the key prop down to the actual TableRow component.
  2. The table header was not correctly using the <h3> tag, which cannot be a direct child of TableHead

I fixed these errors, sorry for the small PR.

@andy89923 andy89923 self-requested a review May 8, 2024 15:45
@andy89923 andy89923 changed the title Fix rendering errors (missing key and h3 child of TableHeader) fix: rendering errors (missing key and h3 child of TableHeader) May 8, 2024
@andy89923 andy89923 force-pushed the bugfix/charging_table branch from e5247a6 to 6c0002a Compare May 9, 2024 06:56
@andy89923 andy89923 requested a review from ianchen0119 May 9, 2024 06:58
@ianchen0119
Copy link
Contributor

ianchen0119 commented May 10, 2024

Hi @LaumiH

Thanks for your contribution!

@ianchen0119 ianchen0119 merged commit 420d9ba into free5gc:main May 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants