feat: add configurable page auto-refresh to all pages (in Dashboard) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yccodr Help review this PR! |
|
Hi @LaumiH. However, the commit message in this PR didn't follow https://www.conventionalcommits.org/en/v1.0.0/ we just applied. |
andy89923
changed the title
|
@andy89923 LGTM |
andy89923
force-pushed
the
feature/configurable_auto_reload
branch
from
27eb571 to
6db2e47
Compare
andy89923
force-pushed
the
feature/configurable_auto_reload
branch
from
498dc84 to
3997bd1
Compare
ianchen0119
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a Refresh configuration option to the header of all pages in the webconsole.
The default is set to "manual", so no page auto-refresh.
Upon configuring a different value, the page is automatically refreshed in the configured interval (e.g. every 5s), and the data is reloaded (from the core or the database).
This centralizes the auto-refresh that was hardcoded in the charging page, and makes it configurable.
The values are set in the Dashboard, which is included by every page component, so that the option is available for all pages in the webconsole. If it is not needed, the user can simply leave it at "manual".
Let me know if you find this helpful, or if you find any bugs or improvements!