Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use config file in billing server #98

Merged
merged 4 commits into from
May 23, 2024

Conversation

andy89923
Copy link
Collaborator

@andy89923 andy89923 commented May 17, 2024

Description

  • BillingServer uses config files setting (version 1.0.3)
  • Update golangci-lint settings to comply with v1.57.2

@yccodr
Copy link
Collaborator

yccodr commented May 17, 2024

@andy89923 gomnd settings suggestion:

  gomnd:
    # !important in golangci-lint v1.58.0, gomnd is replaced by mnd
    # List of enabled checks, see https://github.com/tommy-muehle/go-mnd/#checks for description.
    # Default: ["argument", "case", "condition", "operation", "return", "assign"]
    checks:
      - argument
      - case
      - condition
      - operation
      - return
      - assign
    # List of numbers to exclude from analysis.
    # The numbers should be written as string.
    # Values always ignored: "1", "1.0", "0" and "0.0"
    # Default: []
    ignored-numbers:
    # List of file patterns to exclude from analysis.
    # Values always ignored: `.+_test.go`
    # Default: []
    ignored-files:
    # List of function patterns to exclude from analysis.
    # Following functions are always ignored: `time.Date`,
    # `strconv.FormatInt`, `strconv.FormatUint`, `strconv.FormatFloat`,
    # `strconv.ParseInt`, `strconv.ParseUint`, `strconv.ParseFloat`.
    # Default: []
    ignored-functions:
      - 'os\.Mkdir'
      - 'os\.MkdirAll'
      - '^math\.'
      - '^http\.StatusText$'

@andy89923 andy89923 requested a review from ianchen0119 May 21, 2024 03:39
@andy89923 andy89923 changed the title fix: update golangci-lint setting feat: use config file in billing server May 22, 2024
@andy89923 andy89923 force-pushed the fix/golangci-lint branch from 402fb1c to 21055d6 Compare May 22, 2024 06:19
@ianchen0119 ianchen0119 merged commit 879e9f0 into free5gc:main May 23, 2024
3 checks passed
@andy89923 andy89923 deleted the fix/golangci-lint branch May 23, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants