Fixbug no file exist check #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevending1st |
stevending1st
approved these changes
May 8, 2022
|
fileExistCheck 返回的 false 将被 try catch 先捕捉到，直接先运行错误处理逻辑， 退出爬虫，造成爬虫失败。 逻辑将改为 这是不是新增爬虫（没文件是新增爬虫， 有文件则不是）。 #15 从原来的回调 ，变成这种 await promise相关结合，还是不太习惯。 |
TechQuery
reviewed
May 13, 2022
| @@ -31,6 +31,10 @@ const { | |||
| const articleFileName = await haveRouterAddrmd(articleChildRouter); | |||
| const htmlString = await (await nodeFetch(URL, options)).text(); | |||
| const articleText = await HTMLtoMarkdown(htmlString); | |||
|
|
|||
| if (await fileExistCheck(input.markDownFilePath + articleFileName)) { | |||
| return Promise.reject("file has exist"); | |||
There was a problem hiding this comment.
async 函数里可以用同步的思维写
throw new Error('file has exist');
Comment on lines
+49
to
+52
| exports.fileExistCheck = (path) => | ||
| new Promise((resolve, reject) => { | ||
| fs.existsSync(path)? resolve(true) : reject(false); | ||
| }); |
There was a problem hiding this comment.
我只是看到里面代码大部分是这样的， 就想保持语法风格的统一。
There was a problem hiding this comment.
我只是看到里面代码大部分是这样的， 就想保持语法风格的统一。
不能形式大于内容，过多异步也拖性能。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist（清单）:
Update index.md)（我的 pull request 有一个详细的标题，而不是像“添加 index.md 文件这样的粗略标题”。）mainbranch of this repo.（我的 pull rewuest 基于本仓库main分支修改。）Closes #11