feat: add second OOP lab #585
Conversation
ihechikara
added
Frontend Cert
Labs Team
ihechikara
requested review from
moT01,
fhsinchy,
zairahira,
larymak and
Dario-DC
There was a problem hiding this comment.
Hey @ihechikara !
I think the project itself works well but the user stories overall are to strict and step by step.
Remember the goal of the labs is for campers to build things on their own and think through the problems. That is the only way you grow and learn as a developer.
If everything is prescribed to them in a step by step fashion, then they don't really need to think through what to do because they are just going through the motions of a tutorial.
I left some comments on where we should generalize things to make this more open ended so it matches what is currently merged into main.
| @@ -0,0 +1,38 @@ | |||
| 1. You should define a class named `BankAccount` with a `constructor` that has a `balance` parameter (default value of 0). The constructor should also initialize an empty `transactions` array to store transaction records. | |||
There was a problem hiding this comment.
| 1. You should define a class named `BankAccount` with a `constructor` that has a `balance` parameter (default value of 0). The constructor should also initialize an empty `transactions` array to store transaction records. | |
| 1. You should define a class named `BankAccount` with a `constructor` that has a `balance` parameter. The default parameter value should be set to `0`. The constructor should also initialize an empty `transactions` array to store transaction records. |
| - Check if the `amount` is greater than 0. | ||
| - If the amount is valid, push an object with the properties `type: 'deposit'` and the `amount` into the `transactions ` array. | ||
| - Call the `updateBalance` method to update the account's balance. | ||
| - Log a message to the console indicating the deposit was successful and display the new balance. | ||
| - If the `amount` is invalid, log an error message indicating that the deposit amount must be greater than zero. |
There was a problem hiding this comment.
this is too step by step and doesn't allow the camper to think through what needs to be done.
this should be more generalized so the camper is forced to think about how to solve the problem
There was a problem hiding this comment.
Also, it will be much easier from a testing perspective to return the string instead of logging it to the console.
| - Check if the `amount` is greater than 0 and less than or equal to the current `balance`. | ||
| - If valid, push an object with the properties `type: 'withdraw'` and the `amount` into the `transactions` array. | ||
| - Call the `updateBalance` method to update the account's balance. | ||
| - Log a message to the console indicating the withdrawal was successful and display the new balance. | ||
| - If the `amount` is invalid or exceeds the balance, log an error message indicating insufficient balance or invalid amount. |
There was a problem hiding this comment.
same issue here.
This should be more generalized to have camper think more about what needs to be done and not so step by step.
| - Log a message to the console indicating the withdrawal was successful and display the new balance. | ||
| - If the `amount` is invalid or exceeds the balance, log an error message indicating insufficient balance or invalid amount. | ||
|
|
||
| 4. You should define a method named `checkBalance` that logs the current account balance to the console. |
There was a problem hiding this comment.
we should just have them return the string instead of logging it.
it will be much easier to test that way
| - Use the `reduce` function to sum the transactions in the `transactions` array. | ||
| - Update the `balance` by adding up all the deposit amounts and subtracting all the withdrawal amounts. |
There was a problem hiding this comment.
this one too should be more generalized.
we should allow for multiple valid answers but right now we are only asking them to user reduce but there are multiple ways to solve this
| - Use the `filter` function to create a new array containing only the transactions with `type: 'deposit'`. | ||
| - Use the `map` function to extract the `amount` from each deposit transaction. | ||
| - Log the list of deposit amounts to the console and return this list. |
There was a problem hiding this comment.
we should be more general here to and say something like "Return an array containing the amounts from each deposit transaction."
also, we should remove the log statement here.
| - Use the `filter` function to create a new array containing only the transactions with `type: 'withdraw'`. | ||
| - Use the `map` function to extract the `amount` from each withdrawal transaction. | ||
| - Log the list of withdrawal amounts to the console and return this list. |
There was a problem hiding this comment.
this could be updated to something like "Return an array containing the amounts from each withdrawal transaction."
also, we should remove the log statement here.
| 8. You should create an instance of the BankAccount class named myAccount. Then, you should: | ||
| - Use the `deposit` method to deposit into the account. | ||
| - Use the `withdraw` method to withdraw from the account. | ||
| - Use the `checkBalance` method to log the current balance to the console. | ||
| - Use the `listAllDeposits` method to list all deposits made. | ||
| - Use the `listAllWithdrawals` method to list all withdrawals made. |
There was a problem hiding this comment.
IMO, I don't think we really need this last part.
Checklist:
Update index.md)Closes #470