feat(tools): create ui-components package and setup Storybook #41920

huyenltnguyen · 2021-04-24T20:09:17Z

Checklist:

I have read freeCodeCamp's contribution guidelines.
My pull request has a descriptive title (not a vague title like Update index.md)
My pull request targets the main branch of freeCodeCamp.
All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Description

This PR sets up Storybook in the client folder. I try to keep the PR small with some basic configs, and will have follow-up PRs to iterate. Storybook right now has a stub component that was generated by Storybook's installation script.

To start it, run:

npm run storybook

I will add comments to the code to give a better explanation, but here is a breakdown of what I did:

I followed the Installation doc and ran npx sb init inside /client. The script creates a .storybook folder right under /client, and a stories folder under /client/src
The components files were actually created in TypeScript, I deleted most of them, kept the Button component only and converted it to JavaScript. The component list that the script generates can be found here, and the generated introduction file can be found here
Installed @storybook/addon-postcss as a dev dependency and added it to the .storybook/main.js config
Installed dotenv-webpack and html-webpack-plugin as dev dependencies as a workaround for Webpack5: start-storybook fails when .env is present storybookjs/storybook#14403 (I will elaborate more in the comment)
Themed Storybook a little by adding freeCodeCamp logo
Added the storybook command to the root package.json file

Screenshot

gitpod-io · 2021-04-24T20:09:19Z

client/.storybook/main.js

huyenltnguyen · 2021-04-24T20:14:09Z

client/.storybook/manager.js

@@ -0,0 +1,6 @@
+import { addons } from '@storybook/addons';


This file wasn't generated by the script. I created it as part of the custom theming.

Ref: https://storybook.js.org/docs/react/configure/theming#create-a-theme-quickstart

huyenltnguyen · 2021-04-24T20:14:16Z

client/.storybook/theme.js

@@ -0,0 +1,8 @@
+import { create } from '@storybook/theming';


This file wasn't generated by the script. I created it as part of the custom theming.

Ref: https://storybook.js.org/docs/react/configure/theming#create-a-theme-quickstart

huyenltnguyen · 2021-04-24T20:19:01Z

client/.storybook/theme.js

+  brandImage:
+    'https://cdn.freecodecamp.org/platform/universal/fcc_secondary.svg'
+});


I browsed the cdn repo but couldn't find a logo file that has both text and gray90 background color. I resorted to the secondary logo as the text of the primary one is not readable on Storybook's default background.

We have png assets with set backgrounds on the design style guide. https://github.com/freeCodeCamp/design-style-guide/blob/master/downloads/fcc_primary_large.png but they are not on the CDN.

We could default to the gray85 for the background and use the primary SVG down the road.

I just tried it out and the PNG doesn't seem to have a background either

Storybook has very limited theming options. In order to have a dark background for the primary logo, I would need to set gray85 to the entire sidebar and change the text color; but it affects the Controls panel, which doesn't have dedicated styling options.

So I think we would still need an image file with a set background on CDN if we want to use the primary logo.

huyenltnguyen · 2021-04-24T20:19:22Z

client/package.json

+    "storybook": "start-storybook -p 6006",
+    "build-storybook": "build-storybook"


These were added by the Storybook script.

huyenltnguyen · 2021-04-24T20:20:31Z

client/package.json

+    "@babel/core": "^7.13.16",
+    "@storybook/addon-actions": "^6.2.9",
+    "@storybook/addon-essentials": "^6.2.9",
+    "@storybook/addon-links": "^6.2.9",
+    "@storybook/addon-postcss": "^2.0.0",
+    "@storybook/react": "^6.2.9",
    "@testing-library/jest-dom": "5.12.0",
    "@testing-library/react": "11.2.6",
    "autoprefixer": "9.8.6",
+    "babel-loader": "^8.2.2",


All of the new dependencies were added automatically by Storybook, except for @storybook/addon-postcss.

huyenltnguyen · 2021-04-24T20:28:27Z

client/package.json

+    "dotenv-webpack": "^7.0.2",
+    "html-webpack-plugin": "^5.3.1",


If I understand storybookjs/storybook#14403 correctly, Storybook is using a very old version of these libraries. They are hoisted and get picked up by Webpack, but error thrown because they are not compatible with Webpack 5.

Apparently Storybook team fixed it but then reverted the PR due to it being backward incompatible (storybookjs/storybook#14403 (comment)). I followed storybookjs/storybook#14497 (comment) and added these packages to our dev dependency list as a workaround.

The Storybook team recommends using Yarn's resolutions to workaround this issue. It is not applicable to us, but I'm just posting the link here for future reference: https://gist.github.com/shilman/8856ea1786dcd247139b47b270912324#yarn-resolutions

huyenltnguyen · 2021-04-24T20:31:26Z

client/src/stories/Introduction.stories.mdx

@@ -0,0 +1,211 @@
+import { Meta } from '@storybook/addon-docs/blocks';
+import Code from './assets/code-brackets.svg';


This file is generated by Storybook, along with a bunch of svg files. It has links to the official document pages, which I think might come in handy especially when we don't have documentation on our side yet.

I decided to keep this one, and we can delete it once our component library is more mature.

raisedadead

Nice work @huyenltnguyen!

I just wanted to drop in and give some quick feedback about the structure. I think the best place to develop and design the components would be within the tools location. We can add additional directory within the tools called ui-components and name the package @freeCodeCamp/ui - not sure we will publish it though.

I say this because we may want to extend the components well beyond their use in the client app (which is architecturally speaking a consumer).

The ability to build components in isolation would force to think of them as generic components vs customizing too much.

IMHO, if we use tailwind with headless-ui I am convinced 90% of our needs will be addressed already.

With storybook we can address the custom needs like layouts, nav and theming.

Thinking ahead when we have additional apps (like a JAMStack news) this could be the common locations to consume components from.

P.S: This will also keep the client app lean.

huyenltnguyen · 2021-04-28T19:09:01Z

@raisedadead Totally agreed! I'm also in favor of keeping the components platform-agnostic, so it makes sense to move it out of client. I was under the impression that we would built the components from scratch, but headless-ui looks promising.

I'll try to get back to this PR over the weekend 😄

In the meantime, I'm wondering if you have any suggestions on the folder structure. Storybook's default structure is quite flat:

stories
├── Button.css
├── Button.js
├── Button.stories.js

I'm thinking about having a folder for each component, which would be consistent with our components folder in client, and an index.js file that serves as an entry point for component export. It should be something like this:

ui-components
├── Button
│   ├── Button.css
│   ├── Button.js
│   ├── Button.stories.js
│   ├── Button.test.js
├── index.js

One thing I completely forgot in the issue discussion is that we should write unit tests for our components as well.

For components that headless-ui doesn't support yet and we need to build ourselves, we should try to ensure accessibility requirements are covered via unit tests. An example could be making sure icon-only buttons have aria-label specified, or disabled buttons have the disabled attribute set, etc..

I have some experience working with Jest and @testing-library/react and I guess I'm going to propose that 😛 But I would like to get some input from the core team on the testing approach as well.

raisedadead · 2021-04-28T19:42:30Z

I like the idea of having a simple flat structure instead of layers like we currently do. One thing to note is that all file names should be kebab-case

As for tests, YESSSS PLEASE!!! we are fans of RTL so that should already align with what we want. Please go ahead.

This reverts commit f55e249.

…/storybook-setup

gitpod-io · 2021-05-02T18:45:08Z

huyenltnguyen

Okay, the PR is ready for another review round.

I reverted the changes to start clean, then:

cd into tools and ran npx sb init --type react. The command is from the Troubleshooting section in the Storybook installation guide
The package.json file generated from the script didn't not include React. I believe this is because Storybook is meant to piggyback a project with a framework installed. I added react and react-dom to the dependencies list to allow Storybook to run
The rest are the same as my initial setup

What I think I'm missing here is the setup for package publication. I will need to read up on this as I have never released a package before.

I will leave Tailwind and RTL setup for another PR. They are already in the TODO list #41580 (comment) 🙂

lerna.json

tools/ui-components/package.json

…/storybook-setup

ahmaxed · 2021-05-10T00:14:48Z

I like the idea of having a simple flat structure instead of layers like we currently do. One thing to note is that all file names should be kebab-case

I also like having a simple structure for the components that share the same hierarchy. Maybe we should consider adding another directory when the components are not atomic and are a combination of UI elements such as forms, navigation, etc.

raisedadead

Going to go ahead merge, and unblock you from spiking further.

raisedadead · 2021-05-10T19:07:57Z

Is is possible to edit this intro view?

Edit: Nevermind, I figured it out.

feat(client): basic Storybook setup

f55e249

github-actions bot added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Apr 24, 2021

huyenltnguyen commented Apr 24, 2021

View reviewed changes

huyenltnguyen marked this pull request as ready for review April 26, 2021 16:19

huyenltnguyen requested a review from a team as a code owner April 26, 2021 16:19

raisedadead reviewed Apr 26, 2021

View reviewed changes

raisedadead added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 27, 2021

huyenltnguyen added 2 commits May 3, 2021 01:35

Revert "feat(client): basic Storybook setup"

3c79671

This reverts commit f55e249.

Merge branch 'main' of github.com:freeCodeCamp/freeCodeCamp into feat…

11f883a

…/storybook-setup

github-actions bot added scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. and removed platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels May 2, 2021

huyenltnguyen changed the title ~~feat(client): basic Storybook setup~~ feat(tools): create ui-components package and setup Storybook May 2, 2021

huyenltnguyen force-pushed the feat/storybook-setup branch from 191afcb to c62919c Compare May 3, 2021 10:52

huyenltnguyen added 2 commits May 4, 2021 22:13

feat(tools): create ui-components package and setup Storybook

9b435b4

Add ui-components to lerna.json

30570be

huyenltnguyen force-pushed the feat/storybook-setup branch from c62919c to 30570be Compare May 4, 2021 15:16

huyenltnguyen mentioned this pull request May 4, 2021

UI Components Library #41580

Closed

43 tasks

huyenltnguyen commented May 4, 2021

View reviewed changes

lerna.json Show resolved Hide resolved

tools/ui-components/package.json Show resolved Hide resolved

tools/ui-components/package.json Show resolved Hide resolved

tools/ui-components/package.json Show resolved Hide resolved

huyenltnguyen added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 4, 2021

Merge branch 'main' of github.com:freeCodeCamp/freeCodeCamp into feat…

ea07839

…/storybook-setup

ahmaxed self-requested a review May 6, 2021 11:07

raisedadead approved these changes May 10, 2021

View reviewed changes

raisedadead merged commit 3efe3fa into freeCodeCamp:main May 10, 2021

huyenltnguyen deleted the feat/storybook-setup branch May 11, 2021 05:58

ahmaxed mentioned this pull request Jan 4, 2022

UI Components Library #44668

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tools): create ui-components package and setup Storybook #41920

feat(tools): create ui-components package and setup Storybook #41920

huyenltnguyen commented Apr 24, 2021 •

edited

Loading

gitpod-io bot commented Apr 24, 2021

huyenltnguyen Apr 24, 2021

huyenltnguyen Apr 24, 2021

huyenltnguyen Apr 24, 2021 •

edited

Loading

ahmaxed May 10, 2021

huyenltnguyen May 11, 2021

huyenltnguyen Apr 24, 2021

huyenltnguyen Apr 24, 2021

huyenltnguyen Apr 24, 2021 •

edited

Loading

huyenltnguyen Apr 24, 2021

huyenltnguyen Apr 24, 2021

raisedadead left a comment •

edited

Loading

huyenltnguyen commented Apr 28, 2021

raisedadead commented Apr 28, 2021

gitpod-io bot commented May 2, 2021

huyenltnguyen left a comment

ahmaxed commented May 10, 2021

raisedadead left a comment

raisedadead commented May 10, 2021 •

edited

Loading

		"storybook": "start-storybook -p 6006",
		"build-storybook": "build-storybook"

		@@ -0,0 +1,211 @@
		import { Meta } from '@storybook/addon-docs/blocks';
		import Code from './assets/code-brackets.svg';

feat(tools): create ui-components package and setup Storybook #41920

feat(tools): create ui-components package and setup Storybook #41920

Conversation

huyenltnguyen commented Apr 24, 2021 • edited Loading

Description

Screenshot

gitpod-io bot commented Apr 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huyenltnguyen Apr 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huyenltnguyen Apr 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raisedadead left a comment • edited Loading

Choose a reason for hiding this comment

huyenltnguyen commented Apr 28, 2021

raisedadead commented Apr 28, 2021

gitpod-io bot commented May 2, 2021

huyenltnguyen left a comment

Choose a reason for hiding this comment

ahmaxed commented May 10, 2021

raisedadead left a comment

Choose a reason for hiding this comment

raisedadead commented May 10, 2021 • edited Loading

huyenltnguyen commented Apr 24, 2021 •

edited

Loading

huyenltnguyen Apr 24, 2021 •

edited

Loading

huyenltnguyen Apr 24, 2021 •

edited

Loading

raisedadead left a comment •

edited

Loading

raisedadead commented May 10, 2021 •

edited

Loading