This repository has been archived by the owner on Aug 28, 2019. It is now read-only.
Added Bootstrap JS and jQuery Scripts, and added Bootstrap Modal article #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichaelDurfey thanks for the PR, we really appreciate it. Please see the conversation in #114 as to why I don't want to include jQuery and bootstrap.js on the site. Maybe there is a way we can write this article as a react component, that way we can use |
|
@Bouncey I thought this may be an issue. I'll see what I can do. Thanks. |
|
this file has conflict. |
|
Closing as stale. Please make appropriate changes if you have the time. @Bouncey feel free to open this is you still want changes on this. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Bootstrap JS and jQuery CDNs because these are needed to have a live working demo on the guides. Is this ill-advised? I can remove if so.
Let me know any thoughts you might have.