Test security module against actual indentity.

[A4Vision]

Simplify the tests, compare client usage against direct usage of Identity.

[realcr]

@A4Vision : The purpose of this test was to make sure that RequestPublicKey returns a consistent result from the security module (Even when called twice). I propose one of the following:

1. Add the comparison of actual_public_key against public_key1
2. Leave this test as it is, and add a new test that compares actual_public_key and public_key_from_client.

[A4Vision]

Good eye ! I see - I did weaken the test, so I fix it to solution 1.
In this case, a "for" loop is simpler than previous code - so I add a for loop.

[realcr]

@A4Vision : The tests in this module were meant to check the interface of SecurityModule. Indeed we can make the tests shorter if we use the internal identity directly, but then we are relying on the underlying interface of identity.

I think that the tests should only deal with the interface of SecurityModule. If we call methods of identity directly we mix the two interfaces. What is your opinion?

[A4Vision]

The tests in this module were meant to check the interface of SecurityModule ... we are relying on the underlying interface of identity.

@realcr : Generally I agree that separating testing of interfaces is better when reasonable.
In this specific case, the length is more significant.

In the second test (test_security_module_request_sign), I think the modified test is better because it separates the test of getting the public key from the test of getting a signature.

[realcr]

@A4Vision : I restarted the travis job, because it seemed to fail on the famous timer test. Hopefully it will pass this time.

Regarding the second test: fn test_security_module_request_sign, I think that each of us wants to test something a bit different. The way I see it, I think that it is very important to test the interface of SecurityModule, and for you it is important to have a short test.

I propose that you add another test with the code the you like (Directly calling let public_key = identity.get_public_key();). Having an extra test always upgrades the party.

[A4Vision]

I propose that you add another test

Done.

Discussing it any further simply does not worth our time.

[realcr]

Upstream problem with rust compiler + clippy, reported here:
rust-lang/rust#49114

[kamyuentse]

I will submit a PR to freeze the rust version in CI. real <notifications@github.com>於 2018年3月18日 週日，上午6:18寫道：

…

Upstream problem with rust compiler + clippy, reported here: rust-lang/rust#49114 <rust-lang/rust#49114> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AO0XaYzFk_Bo81IRzg-OsHeflGfTZoILks5tfYvGgaJpZM4SlsQi> .