This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Updates python requirements with security fixes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 6, 2020 12:05
Based on local `safety check -r requirements.txt`, which reported: │ REPORT │ │ checked 73 packages, using default DB │ ╞════════════════════════════╤═══════════╤══════════════════════════╤══════════╡ │ package │ installed │ affected │ ID │ ╞════════════════════════════╧═══════════╧══════════════════════════╧══════════╡ │ psutil │ 5.6.3 │ <=5.6.5 │ 37765 │ │ pyyaml │ 5.1.2 │ <5.3.1 │ 38100 │ │ urllib3 │ 1.25.2 │ >=1.25.2,<=1.25.7 │ 27519 updated those three packages and everything's happy again. Also updated Ansible 2.7.14 -> 2.7.16 for CVE-2019-14864, which 'safety' didn't complain about, but GitHub security alerts did.
The Ansible intepreter was still set to python2, which went EOL on 2020-01-01. Moving to python3 requires a few package/syntax updates in various places.
We'd implemented retry logic because occasionally the fetch tasks for grsec patches would fail. Newer versions of Ansible & Python have changed how the try logic operates in tandem with loops. Rather than debug the syntax changes, let's raise the timeout and expect the task to complete.
Removes unused vagrant-based scenarios
conorsch
force-pushed
the
update-pip-deps-2020-04-02
branch
from
638c1f8 to
38d80f3
Compare
This was referenced Apr 7, 2020
|
Ended up with a larger diff than I'd hoped, but we were overdue on the pip dependencies updates, as well as the py2 -> py3 change. Successfully built SD core kernels on this PR, artifacts in freedomofpress/securedrop-apt-test#37 Still need to append the new config to this PR, though. |
Copied out of the source tarball, changes are quite minimal.
emkll
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Thanks @conorsch , changes look good to me:
- CI is passing
-
safety check -r requirements.txtlocally shows no vulns - visual diff of the config/molecule changes
- config is exactly the same as kernel provided in Update SecureDrop grsec kernels to 4.14.175 securedrop-apt-test#37
Approving (but not merging) due to what seem like test issues reported in
freedomofpress/securedrop#5188 (review)
emkll
approved these changes
Apr 8, 2020
There was a problem hiding this comment.
Tests are now passing locally in freedomofpress/securedrop#5188, merging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on local
safety check -r requirements.txt, which reported:updated those three packages and everything's happy again.
Also updated Ansible 2.7.14 -> 2.7.16 for CVE-2019-14864, which 'safety'
didn't complain about, but GitHub security alerts did.
Testing / review
safety check -r requirements.txtlocally shows no vulns