-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from CircleCI runners to Github actions #907
Conversation
3a9bb59
to
1454b39
Compare
Here are the changes I did in this PR, which is up for discussion: "dev" environments ( I'm currently using the ghcr, but I'm wondering if using a cache instead would be more beneficial, because we could invalidate the cache more easily, and rebuild the dev images on the fly if needed. The dangerzone container image is also built daily, cached and uploaded to the ghcr. "end user" ( While doing these changes, the We might want to follow the same lead for the main container image With these changes, the CI is now taking ~9mn to complete all the tests! 🐎 |
1454b39
to
0c31343
Compare
I'm currently using the ghcr for the dev images, but I'm leaning towards getting it (almost) out of the picture, as I'm not sure it makes more sense than using a cache with This last option will make it easier to invalidate the cache if for instance the dependencies change. But maybe I'm missing the main point why you wanted to have a look at the ghcr in the first place @apyrgio ? |
Damn, super exciting work Alexis! I'll dig into it soon. On the subject of caching, I'm wondering how is the invalidation story different for caches, instead of container images? I'm definitely missing context here since I have theorized about this working, but I didn't implement it as you did. In any case, I suggested pushing to a container registry instead of creating a tarball for the following reasons:
That's mostly it, but I'd like to know your experience so far. |
bd9b500
to
f3197f5
Compare
3d4d89b
to
d038418
Compare
f3d6f0b
to
6ac7892
Compare
73d980f
to
1705633
Compare
09aaee2
to
e177c8d
Compare
As part of this change, the dev (build) and end-user test images names changed from `dangerzone.rocks/*` to `ghcr.io`. A new `--sync` option is provided in the `env.py` command, in order to retrieve the images from the registry, or build and upload otherwise.
Add a dummy entry in debian/changelog, to signal that the latest Dangerzone version is 0.7.1.
Make sure that the Debian package we build conforms to the expected naming scheme else, it's possible that something is off. A scenario we've encountered is bumping `share/version.txt`, but not `debian/changelog`, which would create a Debian package with an older version.
e177c8d
to
a001b54
Compare
This is still pretty much a WIP. I'm pushing it here mainly to see how the CI is reacting.
Fixes #674