-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template-consolidation component for buster #65
Conversation
Example from a local container. The package
Hopefully that'll make testing upgrade behavior for consolidation a bit easier. |
Using a dedicated "component" so that we can isolate ongoing development specifically on template consolidation work [0] so that we can evaluate upgrade behavior. While it's frankly acceptable to break "apt-test" packages temporarily, we need the ability to test before/after states to evaluate behavior during upgrades. Thus the separate component. Requires updates to the CD logic that runs on apt-test.
This package supersedes and replaces the "securedrop-workstation-sd-svs-disp" package, see freedomofpress/securedrop-workstation#615
Updates the config filepath in the rpc spec. Related PRs: * freedomofpress/securedrop-proxy#79 * freedomofpress/securedrop-builder#198
Strictly for use with template-consolidation channel, for debugging. Again, see related PR in: freedomofpress/securedrop-builder#198
42b13fb
to
e4ef537
Compare
Marking as ready-for-review. I propose we merge these changes into the apt-test "main" branch, so that we can continue to iterate on packages specifically related to freedomofpress/securedrop-workstation#471 , while preserving the regular apt-test setup in use in many different contexts. |
Debs for 1.6.0~rc2 are visible on apt-test: https://apt-test.freedom.press/pool/main/s/securedrop-app-code/ Mentioning because apt-test is currently tracking this feature branch, which has been rebased to include #66 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed via apt-cache in a VM. LGTM
Status
Ready for review
Description of changes
Using a dedicated "component" so that we can isolate ongoing development
specifically on template consolidation work [0] so that we can evaluate
upgrade behavior. While it's frankly acceptable to break "apt-test"
packages temporarily, we need the ability to test before/after states to
evaluate behavior during upgrades. Thus the separate component.
Requires updates to the CD logic that runs on apt-test.
Towards freedomofpress/securedrop-workstation#471
Contains newly built packages based on changes in freedomofpress/securedrop-builder#198
Checklist
securedrop-proxy
version available in the "main" pool is some nightly of 0.3.0: https://apt-test.freedom.press/pool/main/s/securedrop-proxy/securedrop-proxy
version available in the "template-consolidation" pool is at least 0.3.1 (included in this PR): https://apt-test.freedom.press/pool/template-consolidation/s/securedrop-proxy/Confirming the above, since apt-test is currently tracking this feature branch, is essentially verifying the following apt cache output:
except you don't have to mangle your apt sources locally.