Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Babel to build requirements #270

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Conversation

cfm
Copy link
Member

@cfm cfm commented Sep 2, 2021

For freedomofpress/securedrop-client#1294 towards freedomofpress/securedrop-client#1283:

  1. adds Babel 2.9.1 to build requirements; and
  2. brazenly signs the resulting checksums, even though I am not a maintainer, so that freedomofpress/securedrop-client@7959f37 can use this branch in testing. :-)

IMPORTANT. At a minimum, a maintainer will need to rebase out 1c12f46 and resign the checksums as usual:

$ # now let us sign the list of sha256sums
$ gpg --armor --output bootstrap-sha256sums.txt.asc --detach-sig  bootstrap-sha256sums.txt
$ # We can even verify if we want
$ BOOTSTRAP=true ./scripts/verify-sha256sum-signature
$ # Update the build-requirements.txt file
$ PKG_DIR=$PWD BOOTSTRAP=true ./scripts/update-requirements

Test plan

In addition to the usual requirements for a maintainer to approve a new or updated dependency here:

  1. CI passes here
  2. CI passes for freedomofpress/securedrop-client@7959f37

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review in progress... just double-checking with @kushaldas first about intentions around diff reviewing the more recent addition of the bootstrap deps

@sssoleileraaa sssoleileraaa self-assigned this Sep 11, 2021
@kushaldas
Copy link
Contributor

@creviera We should do diff-review for any changes to bootstrap. Also the wheels should be rebuild to verify and hash(s) should be matched against upstream.

@sssoleileraaa
Copy link
Contributor

This is currently blocked by #274

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update is good.

  • CI is passing
  • There are diff-reviews

Approved.

@kushaldas kushaldas merged commit c4f7822 into main Sep 23, 2021
@cfm cfm mentioned this pull request Jan 19, 2022
cfm added a commit that referenced this pull request Jan 25, 2022
…translations"

This reverts commit c4f7822, reversing
changes made to 37678d7.
@legoktm legoktm deleted the sdc-1283-package-translations branch November 26, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants