-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds Babel to build requirements #270
Conversation
1c12f46
to
e7224f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in progress... just double-checking with @kushaldas first about intentions around diff reviewing the more recent addition of the bootstrap deps
@creviera We should do diff-review for any changes to bootstrap. Also the wheels should be rebuild to verify and hash(s) should be matched against upstream. |
This is currently blocked by #274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update is good.
- CI is passing
- There are diff-reviews
Approved.
For freedomofpress/securedrop-client#1294 towards freedomofpress/securedrop-client#1283:
IMPORTANT. At a minimum, a maintainer will need to rebase out 1c12f46 and resign the checksums as usual:
Test plan
In addition to the usual requirements for a maintainer to approve a new or updated dependency here: