Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apostrophes are replaced with HTML entity codes in messages, replies. #175

Closed
zenmonkeykstop opened this issue Nov 15, 2018 · 1 comment
Closed

Apostrophes are replaced with HTML entity codes in messages, replies. #175

zenmonkeykstop opened this issue Nov 15, 2018 · 1 comment
Labels
bug Something isn't working
Milestone
Initial beta release

Comments

@zenmonkeykstop
Copy link
Contributor

zenmonkeykstop commented Nov 15, 2018 •
edited
Loading

If a message contains an apostrophe , ie I'm a message, the text will be rendered as I&#x27m a message in the client.

Note that this isn't always the case - the message & # " ' <a href="foo"> rendered correctly.
@eloquence eloquence added the bug Something isn't working label Nov 15, 2018
@redshiftzero redshiftzero added this to the 0.1.0beta milestone Nov 15, 2018
@ultimatecoder
Copy link
Contributor

Thanks @zenmonkeykstop for such detailed observation 😃

I am trying to fix this issue. Will update here as soon as I will create the PR.

ultimatecoder added a commit to ultimatecoder/securedrop-client that referenced this issue Nov 17, 2018
@ultimatecoder
Fix for displaying quote based messages in conversation
a53625c 
In conversation, messages with single quote (') or double quote(") quote
wasn't rendered correct. It was difficult for journalist to read those
messages. This commit is fixing that problem of parsing quote based
messages and improves readability of the text in the conversation.

Resolves: freedomofpress#175
@ultimatecoder ultimatecoder mentioned this issue Nov 17, 2018
Merged
@ultimatecoder ultimatecoder mentioned this issue Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Initial beta release
Development

No branches or pull requests
4 participants
@eloquence @zenmonkeykstop @ultimatecoder @redshiftzero