-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge current migration before release to reduce number of migrations that must occur #48
Comments
yep, we should definitely squash migrations prior to beta |
Note that if #112 is merged, we must implement this before the beta is rolled out. |
I want to reopen this for a couple reasons. First, there was an annoying error in the first migration, namely that we defined a constraint on a column in the migration as Additionally in order to support #203, #207, and #170, we need to write some annoying migrations that require dropping tables and either bulk or iteratively inserting columns. These lead to a significant increase in complexity for implementing #55. The reason discussed with @redshiftzero for adding migrations as new features come in (namely for adding the |
For reference, see the change on this branch: https://github.com/freedomofpress/securedrop-client/tree/alembic-tests |
Ok we can do that since I'm with you that it is pretty cumbersome to write lots of table-dropping SQL migrations, but we should triple check that we are happy with the database structure for the beta release as it will be set in stone as it were. Auditors will be 100% done in a week-ish which means that the only people that need to blow away their client directory are the small number of developers using this on Qubes (let's just ask people to do this once), which I think is acceptable. |
Note that this likely depends on #217. |
Closing this since we are adding database changes to the now single migration script for beta here: https://github.com/freedomofpress/securedrop-client/blob/master/alembic/versions/2f363b3d680e_init.py We also have a note in the README generically describing the process of merging migrations before releases here: https://github.com/freedomofpress/securedrop-client#merging-migrations |
ci: ensure that requirements files are in sync
Additionally, if we implement #47, then we will need to rewrite these anyway to include the new key names.
The text was updated successfully, but these errors were encountered: