provides tooling for interactive localization updates

[cfm]

Description

Closes #1317 by:

1. removing the l10n GitHub Actions workflow added in mechanizes continuous-localization workflow #1282;
2. renaming the Make targets extract-strings and check-strings for clarity;
3. using check-strings in CI to "lint" that the translation catalog has been updated via extract-strings;
4. offering a Git pre-commit hook for check-strings configurable with make hooks; and
5. removing Make targets whose functions can be performed by Weblate add-ons without custom code or tooling.

Step (5) is this pull request's addition over "option A" #1347.

How to think about this pull request

The following gist offers background considerations shared with, and for evaluating this "option B" pull request against, "option A" #1347:

https://gist.github.com/cfm/d3173206f55d7e44152928fcfd215031

Test Plan

To test the developer experience

1. Change a _()-wrapped source string and commit it
2. Push to testing branch like 1348-cfm-testing (where cfm is your GitHub username ;-)
3. Confirm that test-buster fails on make check-strings with the following error message:

   Translation catalog is out of date. Please run "make extract-strings" and commit the changes.

4. Run make hooks (or rerun make venv or your platform-appropriate variant)
5. Try to git commit --all and confirm that the pre-commit hook fails on make check-strings as above
6. Run make extract-strings
7. Retry git commit --all and confirm that the commit succeeds
8. Push to your testing branch
9. Confirm that test-buster passes

To test the Weblate features

1. Ask @cfm to add you as a collaborator on cfm/securedrop-client
2. git remote add cfm git@github.com:cfm/securedrop-client.git
3. git push -f cfm 1348-cfm-testing^:i18n-testing (where 1348-cfm-testing is the testing branch you used above), to push your string change before make extract-strings
4. Reset Weblate from cfm/securedrop-client: https://weblate-sandbox.securedrop.org/projects/securedrop/securedrop-client/#repository
5. Explore Weblate and the pull request it maintains in cfm/securedrop-client
6. git push cfm 1348-cfm-testing:i18n-testing (where 1348-cfm-testing is the testing branch you used above), to push your string change with make extract-strings
7. Update Weblate from cfm/securedrop-client: https://weblate-sandbox.securedrop.org/projects/securedrop/securedrop-client/#repository
8. Continue exploring Weblate and cfm/securedrop-client
   1. Translate the string you changed
   2. Push from Weblate: https://weblate-sandbox.securedrop.org/projects/securedrop/securedrop-client/#repository

Checklist

Before merge

• Remove (option B) from title and close provides tooling for interactive localization updates (option A) #1347 without merging

After merge

• Replicate add-on configuration for the securedrop-client Weblate component from weblate-sandbox to weblate:

For review

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

• I have tested these changes in the appropriate Qubes environment
• I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
• These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

• I have updated the AppArmor profile
• No update to the AppArmor profile is required for these changes
• I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

• I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
• I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
• I need help writing a database migration
• No database schema changes are needed

[cfm]

@creviera, this is ready for your review per #1317 (comment) and our conversation this morning. I've divided the test plan into separate sections for the developer experience and the Weblate workflow. The former is worth stepping through as written; but let me know if you'd like to pair on the latter, since it takes place between the Weblate sandbox and my cfm/securedrop fork to minimize noise here in the official repository.

[cfm]

I realized today that this pull request has neglected to document the addition of make hooks. I've offered a minimal explanation in 0b6a60d and am happy to add further documentation in response to review feedback.

[sssoleileraaa]

this works! exciting to see so many pieces working seamlessly together. nice work, @cfm.

@conorsch - I would merge this now, but want to err on the side of caution until the 0.5.0 release is finalized (would be nice to fix up our release workflow one day so we don't have to halt merging to the client repo during QA but that's for another time!)

[sssoleileraaa]

(I ended up checking the boxes directly in the test plan in the PR description out of laziness- it all checked out)

[cfm]

• Replicate add-on configuration for the securedrop-client Weblate component from weblate-sandbox to weblate:

This post-merge step is done—

—and https://weblate.securedrop.org/projects/securedrop/securedrop-client/ reset from freedomofpress/securedrop-client@main to begin working in the new workflow, looking for the messages.pot template updated in place.