Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppArmor profile for bullseye support #1528

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Jun 23, 2022

Description

Because of packaging changes, we're now using the system's Python interpreter, the actual binary of
which is located at /usr/bin/python3.9 - which we need to allow securedrop-client to run. In addition, there's also a couple C modules loaded by our dependencies which we also want to be loaded properly.

Fixes securedrop-debian-packaging#345

Test Plan

Checklist

  • I have tested these changes in the appropriate Qubes environment
  • I have updated the AppArmor profile
  • No database schema changes are needed

We're now using the system's Python interpreter, the actual binary of
which is located at /usr/bin/python3.9, and allow loading our dependencies' C
modules

Fixes securedrop-debian-packaging#345
@eaon eaon requested a review from a team as a code owner June 23, 2022 19:45
Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected (I copied the altered file into place rather than build a package). The new paths correspond to paths that indeed exist on a Python 3.9/Bullseye system. I think we can remove the Python 3.7 related entries, but that can be done in follow-up.

@eloquence eloquence merged commit 037aff1 into main Jun 23, 2022
@eloquence eloquence deleted the bullseye-apparmor-profile branch June 23, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bullseye securedrop-client nightlies symlink Python binary, causing AppArmor failures
2 participants