-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-side support for VeraCrypt; use QWizard for export #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
force-pushed
the
export-with-json-gui
branch
from
January 31, 2024 02:01
055e9a7
to
5e2c8c1
Compare
rocodes
force-pushed
the
export-with-json-gui
branch
2 times, most recently
from
February 3, 2024 17:43
275b38d
to
f56b49e
Compare
…mpting mount. Pass export_error flag to cleanup method and flush stdout/err before exit.
…on pattern for export service
… export. Checks to ensure files are present are conducted before dialog launch.
…e does not depend on filepaths.
Add Error page for unrecoverable errors.
rocodes
force-pushed
the
export-with-json-gui
branch
from
February 5, 2024 16:23
f56b49e
to
27525f5
Compare
…r, and cleaning up in _cleanup_tmpdir().
I'm planning to merge this into #1777 today for ease of complete review since the underlying export stuff has had a provisional review. I'll copy the test plan over as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #988
Fixes #1733
Fixes #1734
Towards #1729 (would be an easy addition with QWizard
registeredField
if desired)Towards #1723 (on the way)
Fixes #1605
Currently there are still some styling issues that need to be resolved (button styling, animation):
Test Plan (when PR leaves draft mode)
Manual testing test plan
Setup
build-debs.sh
, build securedrop-client packages from the tip of this branch. You will need to check out this branch of the builder repo to pull in thepexpect
wheel if it hasn't been merged yet.) Install thesecuredrop-export
deb insd-large-bullseye-template
, or clone sd-large-bullseye-template and set the cloned template as template for sd-devices-dvm. if you don't want to mess with your sdw install. You will have to adjust rpc policies to copy the .deb into the template; prepend changes to/etc/qubes/policy.d/60-securedrop-workstation.policy
. Shut down the template and sd-devices{-dvm).sd-app
, and runLOGLEVEL=DEBUG securedrop-client
, or givesd-app
a netvm, install git, clone the client repo into sd-app, check out this branch, activate the venv, and then start the client withLOGLEVEL=DEBUG ./run.sh
(observe log in ~/.securedrop_client/logs/client.log).The business
USB detection
LUKS USB unlocking
Successful export
udisksctl unlock -b /path/to/device
at commandline in sd-devices. Locked VC drives are not currently supported)) ( [securedrop-export] [spike] Support Veracrypt #1730)Error behaviour
error_details
)When good people do bad things
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
main
and confirmed that the migration is self-contained and applies cleanlymain
and would like the reviewer to do so