Store decrypted messages / replies in the DB #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
requested review from
sssoleileraaa and
redshiftzero
as code owners
heartsucker
force-pushed
the
store-messages-in-db
branch
from
a35c80f to
d45b7f1
Compare
redshiftzero
changed the title
heartsucker
force-pushed
the
store-messages-in-db
branch
from
d45b7f1 to
57a13b8
Compare
redshiftzero
suggested changes
Mar 26, 2019
There was a problem hiding this comment.
this looks great! works as advertised (also discovered #282 when looking at this PR). some nits and comments inline mostly about making sure we keep comments accurate to prevent confusion
(and fix related tests that were overly mocked)
heartsucker
force-pushed
the
store-messages-in-db
branch
from
57a13b8 to
6675819
Compare
redshiftzero
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores decrypted messages in the database. Pretty simple.
fixes #217
toward #263